[PWGHF] Add max. Sigmac deltaMass cut to reduce the output size. #14147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfaggin
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mmazzilli,
stefanopolitano,
vkucera and
zhangbiao-phy
as code owners
|
O2 linter results: ❌ 0 errors, |
vkucera
reviewed
Dec 9, 2025
Comment on lines
+379
to
+383
|
|
||
| if (deltaMass > deltaMassSigmacRecoMax) { | ||
| /// the reconstructed deltaMass is too large, let's ignore this candidate for TH1 / THnSparse filling | ||
| continue; | ||
| } |
Collaborator
There was a problem hiding this comment.
Why do you need to apply the same condition six times?
Collaborator
Author
There was a problem hiding this comment.
because I fill the objects in 6 different places in my code, depending on data / MC separation and on the mass hypotheses (pKpi vs. piKp)
MattOckleton
pushed a commit
to MattOckleton/O2Physics
that referenced
this pull request
Jan 14, 2026
mapalhares
pushed a commit
to mapalhares/O2Physics
that referenced
this pull request
Jan 20, 2026
fcolamar
pushed a commit
to fcolamar/O2Physics
that referenced
this pull request
Feb 4, 2026
karlazertova
pushed a commit
to karlazertova/O2Physics
that referenced
this pull request
Feb 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Value left to a very large value (
1000) for backward compatibility.@Mingyu3360715